Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone switch on status page (#191) #233

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Timezone switch on status page (#191) #233

wants to merge 4 commits into from

Conversation

icecoldPHP
Copy link
Contributor

With a new option: Browser default.
Timestamp will change depending on settings
Closes #191

icecoldPHP and others added 2 commits February 7, 2025 01:03
@icecoldPHP
Timestamp changes.
7de477d 
With a new option: Browser default.
Timestamp will change depending on settings
@icecoldPHP
Merge branch 'cachethq:main' into fix-191-timezone-issue
903e91b
@jbrooksuk
Copy link
Member

@danjohnson95 what are your thoughts on this? I know we discussed it at Laracon EU.

jbrooksuk
jbrooksuk requested changes Feb 15, 2025
View reviewed changes
Copy link
Member

@jbrooksuk jbrooksuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the timezone is set to Browser and you have the "Show Timezone" setting enabled, you end up with this:

CleanShot 2025-02-15 at 22 55 13@2x

We should probably say "All times are shown in local time".

@icecoldPHP icecoldPHP marked this pull request as draft February 16, 2025 05:52
@icecoldPHP
Copy link
Contributor Author

icecoldPHP commented Mar 7, 2025 •
edited
Loading

When the timezone is set to Browser and you have the "Show Timezone" setting enabled, you end up with this:

CleanShot 2025-02-15 at 22 55 13@2x

We should probably say "All times are shown in local time".

@jbrooksuk
I could also just show the user's browser local timezone.
Because depending on the browser settings local timezone can be different.
since somebody can choose to set a different timezone for the browser

@icecoldPHP icecoldPHP marked this pull request as ready for review March 7, 2025 22:17
@icecoldPHP icecoldPHP requested a review from jbrooksuk March 7, 2025 22:17
@icecoldPHP icecoldPHP changed the title Timezone switch on status page Timezone switch on status page (#191) Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrooksuk jbrooksuk Awaiting requested review from jbrooksuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schedule TZ not correct
2 participants
@icecoldPHP @jbrooksuk