Minor tweaks

[elliotfehr]

No description provided.

[jbrooksuk]

@elliotfehr I've always added chmod to the post-install-cmd because otherwise log files don't get written to etc. @Ehesp or @manavo have either of you had a good experience not doing so?

Other than that, if you rebase I'll merge these changes in. Thanks @elliotfehr

[manavo]

@jbrooksuk I've had to do it previously, but I did it as part of the deployment process (not as a post-install-cmd). Can probably make it a bit stricter than 777, but depends on what users belong to what group.

[jbrooksuk]

@manavo using Dokku we need to do it as post-install-cmd so the same would apply for Heroku here too. I think we could get away with 755, but it's a requirement.

@elliotfehr can you put the post-install-cmd back in as 755 and then we'll merge the changes. Cheers.

[manavo]

@jbrooksuk don't disagree that it needs to be done, it's definitely needed. Just saying that it could be a separate thing that's done, instead of being a composer post-install-cmd (like running migrations for example).

[jbrooksuk]

@manavo I think that it needs to be done within post-install-cmd for deploying to Heroku.

[jbrooksuk]

@elliotfehr I've fixed up your changes and will merge separately. Cheers :)