Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and update a metric. #40

Merged
merged 3 commits into from
Nov 25, 2014
Merged

Create and update a metric. #40

merged 3 commits into from
Nov 25, 2014

Conversation

jbrooksuk
Copy link
Member

No description provided.

*
* @return Metric
*/
public function postIncidents() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste error? Should be postMetrics?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

manavo added a commit that referenced this pull request Nov 25, 2014
Create and update a metric.
@manavo manavo merged commit 6437a4f into master Nov 25, 2014
@manavo manavo deleted the metric-api branch November 25, 2014 21:52
@@ -1,5 +1,32 @@
<?php

class Metric extends Eloquent {
use \Watson\Validating\ValidatingTrait;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No leading slash is required.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found whilst working on Hippo that if you start namespacing things, it's good to prefix it with a slash as to make it "fully qualified". We had issues before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not required for imports.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully qualified names don't have the leading slashes by definition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's exactly where the problem lay last time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey dokey, we can get them removed, but I'm still 100% sure that there was a reason we ended up having to do that (not for traits, since we don't use them).

@CuReSoft CuReSoft mentioned this pull request Jan 4, 2015
@flemzord flemzord mentioned this pull request May 20, 2015
@jenolan jenolan mentioned this pull request May 20, 2015
@GrahamCampbell GrahamCampbell modified the milestone: V0.1.0 Alpha Jul 25, 2015
@efriel efriel mentioned this pull request May 30, 2017
@raffus raffus mentioned this pull request Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants