-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added subscribers migration with accompanying model #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better extend with #36, no? |
#36 is more related to third-party integration, I'd say? |
Well, we can build a generic interface and make it easy to extend. |
@jbrooksuk maybe add the soft deletes trait as well? (seeing as the DB column is there) |
@pedrommone sure, but we'd need a place to catch subscribers, right? @manavo good catch, added. |
@jbrooksuk better make one step, then we figure out how to implement the #36 |
manavo
added a commit
that referenced
this pull request
Nov 25, 2014
Added subscribers migration with accompanying model
Closed
Closed
Closed
Closed
Closed
3 tasks
Closed
Closed
This was referenced Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribers will simply register their email address and on an incident/component status change, they'll get an email.