Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subscribers migration with accompanying model #38

Merged
merged 2 commits into from
Nov 25, 2014

Conversation

jbrooksuk
Copy link
Member

Subscribers will simply register their email address and on an incident/component status change, they'll get an email.

@pedrommone
Copy link

Better extend with #36, no?

@jbrooksuk
Copy link
Member Author

#36 is more related to third-party integration, I'd say?

@pedrommone
Copy link

Well, we can build a generic interface and make it easy to extend.

@manavo
Copy link
Contributor

manavo commented Nov 25, 2014

@jbrooksuk maybe add the soft deletes trait as well? (seeing as the DB column is there)

@jbrooksuk
Copy link
Member Author

@pedrommone sure, but we'd need a place to catch subscribers, right?

@manavo good catch, added.

@pedrommone
Copy link

@jbrooksuk better make one step, then we figure out how to implement the #36

manavo added a commit that referenced this pull request Nov 25, 2014
Added subscribers migration with accompanying model
@manavo manavo merged commit 467e647 into master Nov 25, 2014
@jbrooksuk jbrooksuk deleted the subscribers-migration branch November 25, 2014 16:36
@CuReSoft CuReSoft mentioned this pull request Jan 4, 2015
@flemzord flemzord mentioned this pull request May 20, 2015
@jenolan jenolan mentioned this pull request May 20, 2015
@GrahamCampbell GrahamCampbell modified the milestone: V0.1.0 Alpha Jul 25, 2015
@efriel efriel mentioned this pull request May 30, 2017
@raffus raffus mentioned this pull request Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants