-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup page #12
Comments
I've started on a really basic setup page. When deploying to Heroku, the success url will take you to it. So far it only creates some settings. |
@jbrooksuk looking at inviting users |
Did you see the |
Hadn't noticed it, but will make use of it! |
We'll most likely need more control in the future, so it's just a starting point. |
We should implement https://github.com/Zizaco/confide, has a good role management. |
@Ehesp what do you think about using Angular here? My thinking is that for adding new items:
It'll be super easy to use two-way data binding without much manual work. |
@Ehesp bump. |
If we just want data binding, Angular might be an overkill? This is a really good library that does just that: http://rivetsjs.com/ |
if Rivet can play nicely with jQuery, it would probably be a better option. From what I see, jQuery is still needed for the Ajax stuff? Basically the thing we need to think about it Blade. If we start to go down the Ajax/data binding route, Blade becomes useless. Then if some pages don't use say Rivet, and others do you've got a mix of different ways of doing the same things which become confusing. Also, since it's done via Ajax your controllers/routes need to behave differently and can't use the default CSRF stuff. In my opinion, it's all or nothing. |
Yep, would need jQuery for all the calls, but we already have jQuery so no overhead there. If we go down the data binding route it makes Blade a bit less useful. But it still has some use for building layouts, etc. CSRF can definitely be used, just need a small tweak: http://stackoverflow.com/a/20446415/349012 |
How would data binding result in Blade being less useful? Serious question, as I'm new to Angular and the concept of two-way data bindings (in that sense). |
You dont necessarily need Angular/jQuery etc for data-binding anyway. Can be done easily enough with native JS, by using the pub sub pattern. Its not tooo difficult, but things like Angular do make it alot easier! |
@manavo Okay cool, we'll write some OOJ anyway for it all :) @ilikeprograms Yeah but it's a lot of manual code to write for the sake of pulling in a package. All we need really is data binding, something to grab the data from the API and we're good to go. |
@Ehesp Mmmm kinda yeah :p I mean its not toooo much work to write a main data-binding controller, but still. Could just use a package, if its not too much overhead etc I guess :) Was just throwing it out there as an option! |
Ok, to make this simpler for all of us, here is my idea:
This does two things:
|
I'm going with my idea above. As such this issue is now closed. |
Update from upstream repo CachetHQ/Cachet
cachethq#6 Provide option to disable external http requests when hosting behind a firewall
When installing from Heroku, it'd be good to have some kind of setup page which:
app_name
,app_url
,show_support
settings.The text was updated successfully, but these errors were encountered: