Rename --gay flag to --rainbow #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
pterjan
requested changes
Nov 11, 2024
| @@ -65,7 +65,7 @@ int main(int argc, char *argv[]) | |||
| { "width", 1, NULL, 'w' }, | |||
| { "termwidth", 0, NULL, 't' }, | |||
| { "filter", 1, NULL, 'F' }, | |||
| { "gay", 0, NULL, 130 }, | |||
| { "rainbow", 0, NULL, 130 }, | |||
There was a problem hiding this comment.
This is incorrect, rainbow already exists and is 132.
| @@ -105,7 +105,7 @@ int main(int argc, char *argv[]) | |||
| if(filter_add(cx, caca_optarg) < 0) | |||
| return -1; | |||
| break; | |||
| case 130: /* --gay (alias to rainbow)*/ | |||
| case 130: /* --rainbow (alias to rainbow)*/ | |||
There was a problem hiding this comment.
This doesn't make sense, rainbow --rainbow is not an alias to --rainbow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
--gayflag to--rainbowin thesrc/main.cfile.long_optionsarray to replace the--gayflag with--rainbow, ensuring consistency with the intended alias for the rainbow filter.--rainbowflag when used.For more details, open the Copilot Workspace session.