Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 1.19 build failing #4252

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

wagyourtail
Copy link
Collaborator

No description provided.

@leijurv leijurv merged commit 0688a57 into cabaletta:1.19.4 Jan 23, 2024
4 checks passed
@ZacSharp
Copy link
Collaborator

What is the difference to #4246?

@ZacSharp ZacSharp mentioned this pull request Jan 23, 2024
4 tasks
@wagyourtail
Copy link
Collaborator Author

the difference is I ping'd leijurv in discord after he complained about it not building

also, I put the version in 1 place so it's easier to change

@ZacSharp
Copy link
Collaborator

also, I put the version in 1 place so it's easier to change

Where's the second place in my pr?

@leijurv
Copy link
Member

leijurv commented Jan 23, 2024

sorry zacsharp

wagyourtail is correct, the only reason why I merged this one is that I got a ping on Discord for it

@ZacSharp
Copy link
Collaborator

I know you don't look here often and if wagyourtail asks you to merge a simple pr I can perfectly understand you not hunting for duplicates first. What irritated me is that wagyourtail apparently didn't see the duplicate, not that you merged this one.

@wagyourtail
Copy link
Collaborator Author

wagyourtail commented Jan 23, 2024

sorry. I usually fix things before checking to see if other people have already done it.

for example... Vineflower/vineflower#337. I went through all that effort, and then checked and saw it was already done and merged in dev, just not on the stable release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants