Repository navigation
Conversation
UseFieldNameByDefault turned MyA into MYA, so MY_A was ignored and the field stayed empty. FooBar already becomes FOO_BAR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseFieldNameByDefaultbuilds the env name intoEnvName. A capital that ends the field was not split from the lowercase letter before it, because that check only ran when another character followed.MyAbecameMYA, soMY_A=setleft the field empty.FooBarwas alreadyFOO_BAR.HTTPanduserIDstayHTTPandUSER_ID.Test plan
toEnvName("MyA")wasMYAbefore the change andMY_AafterParseWithOptionswithUseFieldNameByDefaultandMY_A=setleftMyAempty before the change and readssetaftergo test ./...