#234 - fix: add logic to handle nil pointer structs #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 420 427 +7
=========================================
+ Hits 420 427 +7 ☔ View full report in Codecov by Sentry. |
|
amazing, thank you! |
caarlos0
added a commit
that referenced
this pull request
Jun 19, 2024
* fix: retract v11.0.1, gate init nil pointers as it would automatically initialize nil pointers. this retracts that version, and gate this new feature behind an `init` tag option. closes #317 refs #306 * test: make sure #310 is covered too closes #310 * test: add test for multiple tag options Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: typo * perf: cheap first Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
BorzdeG
pushed a commit
to BorzdeG/env
that referenced
this pull request
Aug 24, 2024
BorzdeG
pushed a commit
to BorzdeG/env
that referenced
this pull request
Aug 24, 2024
* fix: retract v11.0.1, gate init nil pointers as it would automatically initialize nil pointers. this retracts that version, and gate this new feature behind an `init` tag option. closes caarlos0#317 refs caarlos0#306 * test: make sure caarlos0#310 is covered too closes caarlos0#310 * test: add test for multiple tag options Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: typo * perf: cheap first Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the nil pointer structs.
If a struct pointer field is nil, it will be initialised first & then used for further processing.