Repository navigation
Conversation
BREAKING CHANGE: before this, env would set the default value for a variable only if the variable was never set, and would do nothing if it was set to an empty value. After this, it will set the default value if empty as well. closes #245 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 356 358 +2
=========================================
+ Hits 356 358 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
It would great of there is some thing opposite to Example : type user struct {
subscribe `env:"SUBSCRIBE,allowEmpty" envDefault:"yes"`
} |
|
@arvindh123 tbh I think that would be confusing... rather keep it with fewer different behaviors... |
It will be useful and It gives some more flexibility. |
|
Hello, @caarlos0. We plan on using this lib on the Mainflux project here. I agree with Arvindh's comment since it would provide some extra flexibility, but for our needs, this PR is sufficient as is. Any idea when it will be merged? |
|
I still havent made my mind on this... |
|
Okay, I made up my mind. |
BREAKING CHANGE: before this, env would set the default value for a variable only if the variable was never set, and would do nothing if it was set to an empty value. After this, it will set the default value if empty as well.
closes #245