Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom parsers with anon inner structs #227

Merged
merged 3 commits into from
May 30, 2022
Merged

Conversation

caarlos0
Copy link
Owner

fixes #226

it was not passing down the funcmap to the children anon structs, which was causing a weird error in this particular case.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug label May 26, 2022
@caarlos0 caarlos0 self-assigned this May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #227 (c6cb6d7) into main (512d9f8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files           2        2           
  Lines         345      345           
=======================================
  Hits          341      341           
  Misses          4        4           
Impacted Files Coverage Δ
env.go 98.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512d9f8...c6cb6d7. Read the comment docs.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 26, 2022
@caarlos0 caarlos0 merged commit a5d7cf5 into main May 30, 2022
@caarlos0 caarlos0 deleted the 226-bug-byte-conversion branch May 30, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] []byte conversion
1 participant