Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to go 1.15 #150

Merged
merged 2 commits into from
Jan 25, 2021
Merged

feat: upgrade to go 1.15 #150

merged 2 commits into from
Jan 25, 2021

Conversation

@caarlos0
Copy link
Owner

its because we're still building with go 1.14, and this changed in go 1.15... can you also change here to 1.15?

Then the tests should pass I think

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #150 (d3c4e21) into master (80e991b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files           1        1           
  Lines         237      237           
=======================================
  Hits          233      233           
  Misses          2        2           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e991b...d3c4e21. Read the comment docs.

@caarlos0 caarlos0 changed the title Fix escape issue in tests feat: upgrade to go 1.15 Jan 25, 2021
@caarlos0 caarlos0 merged commit aa84092 into caarlos0:master Jan 25, 2021
@caarlos0
Copy link
Owner

Thanks!

nexoscp added a commit to nexoscp/env that referenced this pull request Apr 7, 2022
* Fix escape issue in tests

* Build with Golang 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants