Skip to content

Add support for preventDefault prop on KeyHandler #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanpyle wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for preventDefault prop on KeyHandler #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ab213
Add support for stopPropagation/preventDefault props
dylanpyle May 9, 2024
38f4d91
WIP: testing this is impossible
dylanpyle May 10, 2024
8e4a2c3
Remove failing tests
dylanpyle May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/key-handler/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type KeyboardEventHandler = (event: KeyboardEvent) => void;

interface LeafProp {
handler: KeyboardEventHandler;
preventDefault?: boolean;
}

interface NodeProp {
Expand All @@ -35,6 +36,7 @@ export function KeyHandler(props: KeyHandlerProps) {
const [shouldRenderChildren, setShouldRenderChildren] = useState(false);
const handler = "handler" in rest ? rest.handler : null;
const children = "children" in rest ? rest.children : null;
const preventDefault = "preventDefault" in rest ? rest.preventDefault : false;

useLayoutEffect(
function handlerLifecycle() {
Expand All @@ -44,6 +46,10 @@ export function KeyHandler(props: KeyHandlerProps) {
};
}
const wrappedHandler = (e: KeyboardEvent) => {
if (preventDefault) {
e.preventDefault();
}

if (handler) {
handler(e);
focusedStack.tearDown();
Expand Down