Improve MAF algorithm and add check #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know whether you actually use this filter, but I stumbled upon it and did 2 minor fixes.
Previously, the constructor parameter wasn't checked. The comment on top states that the buffer size can never be larger than MAF_ARRAYSIZE but this wasn't actually checked.
Less importantly, I speeded up the moving average calculation. For window sizes below 20 this didn't make a big difference, but for larger windows the new code still has roughly constant time while the old code takes more time with increasing buffer sizes. I wouldn't mind at all if you rejected this change, just let me know.