Skip to content

Commit

Permalink
vnc: add a more descriptive error message
Browse files Browse the repository at this point in the history
Currently qemu outputs some low-level error in qemu-sockets.c
when failed to start vnc server.
eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known'

Some libvirt users could not know what's happened with this
unclear error message. This patch added a more descriptive
error message.

Signed-off-by: Amos Kong <akong@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
  • Loading branch information
amoskong authored and Stefan Hajnoczi committed Jul 13, 2012
1 parent ab41177 commit 94b204c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion vl.c
Original file line number Diff line number Diff line change
Expand Up @@ -3584,8 +3584,11 @@ int main(int argc, char **argv, char **envp)
/* init remote displays */
if (vnc_display) {
vnc_display_init(ds);
if (vnc_display_open(ds, vnc_display) < 0)
if (vnc_display_open(ds, vnc_display) < 0) {
fprintf(stderr, "Failed to start VNC server on `%s'\n",
vnc_display);
exit(1);
}

if (show_vnc_port) {
printf("VNC server running on `%s'\n", vnc_display_local_addr(ds));
Expand Down

0 comments on commit 94b204c

Please sign in to comment.