feature: add portfolio rebalancing strategy #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
Dec 13, 2021
pkg/strategy/rebalance/strategy.go
Outdated
|
|
||
| func (p *Portfolio) PrintValue() { | ||
| value := p.TotalValue() | ||
| log.Infof("portfolio value: %f %s", value.Float64(), p.BaseCurrency) |
There was a problem hiding this comment.
you can use market.BaseCurrencyFormatter and market.QuoteCurrencyFormatter
c9s
reviewed
Dec 13, 2021
pkg/strategy/rebalance/strategy.go
Outdated
|
|
||
| } | ||
|
|
||
| func (s *Strategy) Rebalance(ctx context.Context, orderExecutor bbgo.OrderExecutor, session *bbgo.ExchangeSession) { |
There was a problem hiding this comment.
if verbose than shows "Rebalancing..." here?
There was a problem hiding this comment.
沒有特別想放什麼，拿掉好了XD
c9s
approved these changes
Dec 13, 2021
narumiruna
force-pushed
the
rebalance
branch
from
6969b47
to
531b221
Compare
c9s
added a commit
that referenced
this pull request
Dec 18, 2021
feature: add portfolio rebalancing strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.