FEATURE: [indicator] porting SuperTrend to indicatorv2#2365
Open
FEATURE: [indicator] porting SuperTrend to indicatorv2#2365
Conversation
Collaborator
dboyliao
commented
Dec 28, 2025
dboyliao
commented
c9s
previously approved these changes
Dec 30, 2025
Owner
|
圖看起來怪怪的 |
c9s
reviewed
Dec 31, 2025
|
|
||
| type SuperTrendBand struct { | ||
| UppderBand float64 | ||
| LowerBand float64 |
Owner
There was a problem hiding this comment.
we can just store one band value and use the direction to remember which side it is ?
Collaborator
Author
There was a problem hiding this comment.
I am thinking we can draw the tunnel if we have both upper and lower band.
That's why I have a method .Band() to do the side selection for convenience.
c9s
approved these changes
Jan 6, 2026
c9s
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.