Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fix OnNew event must be called before OnFilled #1751

Merged
merged 1 commit into from
Sep 26, 2024
Merged

FIX: fix OnNew event must be called before OnFilled #1751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/bbgo/activeorderbook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ func (b *ActiveOrderBook) Add(orders ...types.Order) {
}

b.add(order)
b.EmitNew(order)
}
}

Expand Down Expand Up @@ -424,6 +423,7 @@ func (b *ActiveOrderBook) add(order types.Order) {

b.orders.Add(order)
b.pendingOrderUpdates.Remove(pendingOrder.OrderID)
b.EmitNew(order)

// when using add(order), it's usually a new maker order on the order book.
// so, when it's not status=new, we should trigger order update handler
Expand All @@ -434,6 +434,7 @@ func (b *ActiveOrderBook) add(order types.Order) {

} else {
b.orders.Add(order)
b.EmitNew(order)
}
}

Expand Down
Loading