Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new tag ignore to prevent printing specific field #1743

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lanphan
Copy link
Contributor

@lanphan lanphan commented Sep 13, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @lanphan, This pull request may get 213 BBG.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.02%. Comparing base (336dd7a) to head (dad7b53).
Report is 224 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dynamic/print_config.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   24.11%   24.02%   -0.10%     
==========================================
  Files         615      623       +8     
  Lines       37447    38025     +578     
==========================================
+ Hits         9031     9135     +104     
- Misses      27621    28091     +470     
- Partials      795      799       +4     
Files with missing lines Coverage Δ
pkg/dynamic/print_config.go 0.00% <0.00%> (ø)

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a2203...dad7b53. Read the comment docs.

pkg/dynamic/print_config.go Outdated Show resolved Hide resolved
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 243 BBG

@lanphan lanphan changed the title add new tag disableConfigPrint to prevent printing specific field add new tag unprintable to prevent printing specific field Sep 14, 2024
@lanphan
Copy link
Contributor Author

lanphan commented Sep 20, 2024

@c9s
you want to change field name to ignore: true to be consistent with printdump as Railgun said? He already has PR to add documentation for that

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 251 BBG

@lanphan lanphan changed the title add new tag unprintable to prevent printing specific field add new tag ignore to prevent printing specific field Oct 2, 2024
@lanphan
Copy link
Contributor Author

lanphan commented Oct 2, 2024

@c9s
I update tag name to "ignore", so that it's consistent with document https://github.com/c9s/bbgo/blob/main/doc/topics/rw-strategy.md

Copy link
Owner

@c9s c9s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@c9s c9s merged commit 58133d9 into c9s:main Oct 28, 2024
3 of 5 checks passed
@bbgokarma-bot
Copy link

Hi @lanphan,

Well done! 261 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x9c0d8a0721470e24ee5ab8a13c198987f776606aa31094b6febabcf37bbeaf37

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants