Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [dca2] when all open-position orders are filled, place the t… #1599

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Mar 21, 2024

…ake-profit order

@bbgokarma-bot
Copy link

Welcome back! @kbearXD, This pull request may get 286 BBG.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 12.28070% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 22.63%. Comparing base (693b641) to head (f42ef77).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
+ Coverage   22.57%   22.63%   +0.05%     
==========================================
  Files         619      621       +2     
  Lines       44832    44903      +71     
==========================================
+ Hits        10122    10164      +42     
- Misses      33982    34009      +27     
- Partials      728      730       +2     
Files Coverage Δ
pkg/strategy/dca2/state.go 0.00% <ø> (ø)
pkg/strategy/dca2/recover.go 37.42% <70.00%> (+0.34%) ⬆️
pkg/strategy/dca2/active_order_recover.go 0.00% <0.00%> (ø)
pkg/strategy/dca2/strategy.go 0.70% <0.00%> (-0.02%) ⬇️
pkg/strategy/dca2/background_runner.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693b641...f42ef77. Read the comment docs.

@kbearXD kbearXD force-pushed the kbearXD/dca2/take-profit-order branch from 1f76f94 to 5539764 Compare March 26, 2024 07:52
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 296 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 225 BBG

@kbearXD kbearXD requested a review from lanphan March 27, 2024 06:22
@kbearXD kbearXD merged commit f246077 into main Mar 27, 2024
4 of 5 checks passed
@kbearXD kbearXD deleted the kbearXD/dca2/take-profit-order branch March 27, 2024 08:35
@bbgokarma-bot
Copy link

Hi @kbearXD,

Well done! 316 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x6979709c36ab82e9e88b773d20954f1b15883a9345d19746cc02e13912ad3ffc

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants