FIX: [dca2] must calculate and emit profit at the end of the round #1580
Conversation
kbearXD
requested review from
c9s,
ycdesu,
gx578007,
narumiruna and
bailantaotao
|
Welcome back! @kbearXD, This pull request may get 261 BBG. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 22.40% 22.39% -0.01%
==========================================
Files 615 616 +1
Lines 44436 44459 +23
==========================================
+ Hits 9954 9955 +1
- Misses 33772 33794 +22
Partials 710 710
Continue to review full report in Codecov by Sentry.
|
|
Re-estimated karma: this pull request may get 308 BBG |
kbearXD
force-pushed
the
kbearXD/dca2/profit
branch
from
7b5bee7
to
f29a4be
Compare
|
Re-estimated karma: this pull request may get 313 BBG |
kbearXD
force-pushed
the
kbearXD/dca2/profit
branch
from
f29a4be
to
fb2a46e
Compare
|
Re-estimated karma: this pull request may get 318 BBG |
c9s
changed the title
| return nil | ||
| } | ||
|
|
||
| return retry.GeneralLiteBackoff(ctx, op) |
There was a problem hiding this comment.
What do you think putting all the orders in this round in the returned error for more debug info?
There was a problem hiding this comment.
I will print all the rounds and its orders when calculating.
|
Re-estimated karma: this pull request may get 338 BBG |
|
Hi @kbearXD, Well done! 343 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x302f0acde34b13cb2db86a7b2da34dcf068352502e32055431dfa7003a82df0f Thank you for your contribution! |
No description provided.