-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add SMMA indicator #1553
FEAT: Add SMMA indicator #1553
Conversation
giou-k
commented
Mar 1, 2024
- Add the smma indicator in v2 indicators
- Add a test
Hi @giou-k, This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development. This pull request may get 284 BBG. To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:
Once this pull request is merged, your BBG tokens will be transferred to your wallet. -- Best, |
polygon:0xa3559B630Ca2B5C542eE8640A049b1F344C2d403 |
Great! @giou-k, I've memorized your address. |
source types.Float64Source | ||
} | ||
|
||
func SMMA2(source types.Float64Source, window int) *SMMAStream { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be just SMMA here :-)
Thanks! awesome! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 21.69% 21.74% +0.05%
==========================================
Files 607 608 +1
Lines 43984 44014 +30
==========================================
+ Hits 9543 9573 +30
Misses 33759 33759
Partials 682 682
Continue to review full report in Codecov by Sentry.
|
Hi @giou-k, Well done! 324 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x957c0a03492bdeba4acd8d79a3fcebde8346f47ee2b0d885b052fbcaaa6dfce0 Thank you for your contribution! |