Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add SMMA indicator #1553

Merged
merged 1 commit into from
Mar 4, 2024
Merged

FEAT: Add SMMA indicator #1553

merged 1 commit into from
Mar 4, 2024

Conversation

giou-k
Copy link
Contributor

@giou-k giou-k commented Mar 1, 2024

  • Add the smma indicator in v2 indicators
  • Add a test

@bbgokarma-bot
Copy link

Hi @giou-k,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 284 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@giou-k
Copy link
Contributor Author

giou-k commented Mar 1, 2024

polygon:0xa3559B630Ca2B5C542eE8640A049b1F344C2d403

@giou-k giou-k marked this pull request as ready for review March 1, 2024 10:42
@bbgokarma-bot
Copy link

Great! @giou-k, I've memorized your address.

source types.Float64Source
}

func SMMA2(source types.Float64Source, window int) *SMMAStream {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be just SMMA here :-)

@c9s
Copy link
Owner

c9s commented Mar 2, 2024

Thanks! awesome!

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.74%. Comparing base (6123a4a) to head (0013ec3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   21.69%   21.74%   +0.05%     
==========================================
  Files         607      608       +1     
  Lines       43984    44014      +30     
==========================================
+ Hits         9543     9573      +30     
  Misses      33759    33759              
  Partials      682      682              
Files Coverage Δ
pkg/indicator/v2/smma.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6123a4a...0013ec3. Read the comment docs.

@c9s c9s merged commit 7abc45e into c9s:main Mar 4, 2024
5 checks passed
@bbgokarma-bot
Copy link

Hi @giou-k,

Well done! 324 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x957c0a03492bdeba4acd8d79a3fcebde8346f47ee2b0d885b052fbcaaa6dfce0

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants