Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: [deposit2transfer] improve deposit logging #1531

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Feb 15, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 221 BBG.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d34a410) 21.78% compared to head (c6db392) 21.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
- Coverage   21.78%   21.78%   -0.01%     
==========================================
  Files         606      606              
  Lines       43931    43932       +1     
==========================================
  Hits         9569     9569              
- Misses      33680    33681       +1     
  Partials      682      682              
Files Coverage Δ
pkg/exchange/max/convert.go 22.40% <0.00%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34a410...c6db392. Read the comment docs.

@c9s c9s merged commit 06c533f into main Feb 22, 2024
3 of 5 checks passed
@c9s c9s deleted the c9s/improve-deposit2transfer-logs branch February 22, 2024 14:47
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 231 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x455ed50f44ee18b05fea381c6dd955d0503f312e702fd4bbe771fb9318a2df04

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants