Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: [binance] rewrite binance depth requestgen #1528

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Feb 6, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 520 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 547 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 554 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 580 BBG

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (2f40149) 21.79% compared to head (d015670) 21.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
- Coverage   21.79%   21.78%   -0.02%     
==========================================
  Files         605      606       +1     
  Lines       43900    43931      +31     
==========================================
  Hits         9569     9569              
- Misses      33649    33680      +31     
  Partials      682      682              
Files Coverage Δ
pkg/types/sliceorderbook.go 30.08% <0.00%> (ø)
...g/exchange/binance/binanceapi/get_depth_request.go 0.00% <0.00%> (ø)
pkg/exchange/binance/futures.go 0.00% <0.00%> (ø)
pkg/exchange/binance/exchange.go 1.67% <0.00%> (-0.03%) ⬇️
pkg/exchange/binance/parse.go 18.65% <11.76%> (-0.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f40149...d015670. Read the comment docs.

@c9s c9s force-pushed the c9s/rewrite-binance-depth-requestgen branch from 62dcbb3 to 2cc671b Compare February 6, 2024 07:31
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 584 BBG

@c9s c9s force-pushed the c9s/rewrite-binance-depth-requestgen branch from 2cc671b to d015670 Compare February 6, 2024 07:34
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 595 BBG

@c9s c9s merged commit f186d69 into main Feb 6, 2024
3 of 5 checks passed
@c9s c9s deleted the c9s/rewrite-binance-depth-requestgen branch February 6, 2024 08:03
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 600 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x87d68e91f111ef01b6d37bff136ed8949ac1326422d19c4b5c1b5b014fdeb4c3

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants