Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [binance] add margin request #1525

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

bailantaotao
Copy link
Collaborator

  1. The go-binance library has been deprecated, so I added a new margin request.
  2. We don't need the timestamp because the value is initialized in client.go

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 547 BBG.

// Only for Isolated margin
symbol *string `param:"symbol"`

amount string `param:"amount"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fixedpoint value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

The previous type is because I simply copied the value from another file.
The caller uses req.Price(order.Market.FormatPrice(order.Price))

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 566 BBG

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f77d03d) 21.78% compared to head (836f1f9) 21.77%.
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   21.78%   21.77%   -0.01%     
==========================================
  Files         604      605       +1     
  Lines       43885    43885              
==========================================
- Hits         9559     9558       -1     
- Misses      33643    33645       +2     
+ Partials      683      682       -1     
Files Coverage Δ
...hange/binance/binanceapi/transfer_asset_request.go 0.00% <ø> (ø)
...e/binance/binanceapi/place_margin_order_request.go 0.00% <0.00%> (ø)
pkg/exchange/binance/exchange.go 1.69% <0.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77d03d...836f1f9. Read the comment docs.

@bailantaotao bailantaotao merged commit 1c98e60 into main Feb 6, 2024
3 of 5 checks passed
@bailantaotao bailantaotao deleted the edwin/binance-update-api-changes-3 branch February 6, 2024 02:02
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 586 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x7db8954514e78cfd844526584595c41bbf2ccdc36fccc6874c6cac8b920095cd

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants