Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [binance] update borrow/repay api changes #1524

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

bailantaotao
Copy link
Collaborator

@bailantaotao bailantaotao commented Feb 5, 2024

All changes have been tested on my account.

API changes

https://binance-docs.github.io/apidocs/spot/en/#change-log
2024-01-09

GET /sapi/v1/margin/loan will be removed, please replace with the new POST /sapi/v1/margin/borrow-repay borrowing and repayment interface
GET /sapi/v1/margin/repay will be removed, please replace with the new POST /sapi/v1/margin/borrow-repay borrowing and repayment interface

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 770 BBG.

@bailantaotao bailantaotao changed the title pkg/exchange: update borrow/repay api changes MINOR: [binance] update borrow/repay api changes Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (b6717f2) 0.00% compared to head (f77d03d) 21.78%.
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1524       +/-   ##
=========================================
+ Coverage      0   21.78%   +21.78%     
=========================================
  Files         0      604      +604     
  Lines         0    43885    +43885     
=========================================
+ Hits          0     9559     +9559     
- Misses        0    33643    +33643     
- Partials      0      683      +683     
Files Coverage Δ
pkg/exchange/binance/convert_margin.go 0.00% <ø> (ø)
...anceapi/get_margin_borrow_repay_history_request.go 0.00% <0.00%> (ø)
pkg/exchange/binance/margin_history.go 0.00% <0.00%> (ø)

... and 601 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6717f2...f77d03d. Read the comment docs.

@c9s c9s merged commit 565cdef into main Feb 5, 2024
5 checks passed
@c9s c9s deleted the edwin/binance-update-api-changes-2 branch February 5, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants