Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xdepthmaker] fix double binding #1461

Merged
merged 3 commits into from
Dec 18, 2023
Merged

FIX: [xdepthmaker] fix double binding #1461

merged 3 commits into from
Dec 18, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Dec 18, 2023

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 206 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 231 BBG

@c9s c9s changed the title WIP: FIX: [xdepthmaker] fix duplicated trade FIX: [xdepthmaker] fix double binding Dec 18, 2023
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 235 BBG

@c9s c9s enabled auto-merge December 18, 2023 14:31
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #1461 (c046e73) into main (49896bf) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head c046e73 differs from pull request most recent head 47b12ed. Consider uploading reports for the commit 47b12ed to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   21.32%   21.33%           
=======================================
  Files         591      591           
  Lines       43484    43468   -16     
=======================================
  Hits         9274     9274           
+ Misses      33535    33519   -16     
  Partials      675      675           
Files Coverage Δ
pkg/strategy/xdepthmaker/strategy.go 14.85% <0.00%> (+0.37%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49896bf...47b12ed. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 247 BBG

@c9s c9s merged commit 083f626 into main Dec 18, 2023
2 checks passed
@c9s c9s deleted the c9s/fix-xdepthmaker branch December 18, 2023 14:37
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 252 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x6a7420bc4fd3d3e6f0b8153a11d0bd06682ff8a2d3c39221e31349694595daeb

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants