Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: move common.Strategy to Initialize #1459

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Dec 18, 2023

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @kbearXD, This pull request may get 276 BBG.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #1459 (eda0723) into main (fe2fa19) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1459      +/-   ##
==========================================
- Coverage   21.32%   21.32%   -0.01%     
==========================================
  Files         590      590              
  Lines       43436    43441       +5     
==========================================
  Hits         9262     9262              
- Misses      33499    33504       +5     
  Partials      675      675              
Files Coverage Δ
pkg/strategy/dca2/strategy.go 3.03% <0.00%> (-0.05%) ⬇️
pkg/strategy/xfixedmaker/strategy.go 1.14% <0.00%> (-0.01%) ⬇️
pkg/strategy/liquiditymaker/strategy.go 0.78% <0.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2fa19...eda0723. Read the comment docs.

@c9s c9s merged commit 4bdaf11 into main Dec 18, 2023
2 of 4 checks passed
@c9s c9s deleted the kbearXD/fix/move-common-strategy branch December 18, 2023 07:41
@bbgokarma-bot
Copy link

Hi @kbearXD,

Well done! 286 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x7ccc5075f9901c3baaa96b8dc8dd2be2c16f1874bcad65c25c6356c12b722c9a

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants