Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xdepthmaker] final fix #1458

Merged
merged 4 commits into from
Dec 18, 2023
Merged

FIX: [xdepthmaker] final fix #1458

merged 4 commits into from
Dec 18, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Dec 18, 2023

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 220 BBG.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #1458 (8412295) into main (c71152d) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 12.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1458      +/-   ##
==========================================
- Coverage   21.32%   21.31%   -0.01%     
==========================================
  Files         590      591       +1     
  Lines       43436    43453      +17     
==========================================
  Hits         9262     9262              
- Misses      33499    33516      +17     
  Partials      675      675              
Files Coverage Δ
pkg/exchange/bitget/exchange.go 0.00% <ø> (-0.79%) ⬇️
pkg/bbgo/environment.go 1.30% <0.00%> (-0.01%) ⬇️
pkg/exchange/bitget/debug.go 42.85% <42.85%> (ø)
pkg/strategy/xdepthmaker/strategy.go 14.48% <0.00%> (-0.05%) ⬇️
pkg/exchange/bitget/stream.go 21.36% <0.00%> (-0.62%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71152d...8412295. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 290 BBG

@c9s c9s merged commit 98468fe into main Dec 18, 2023
2 of 4 checks passed
@c9s c9s deleted the feature/xdepthmaker branch December 18, 2023 09:59
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 295 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x95634376c82e5d7f8c69ec8ac2d789f0275fbd2db89fab09cc6a87e8d64bd598

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants