Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [strategy] Add convert strategy #1270

Merged
merged 11 commits into from
Aug 4, 2023
Merged

FEATURE: [strategy] Add convert strategy #1270

merged 11 commits into from
Aug 4, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Aug 4, 2023

This strategy is used for converting specific asset to another asset

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 811 BBG.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1270 (bc8fe22) into main (8118e55) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 11.94%.

❗ Current head bc8fe22 differs from pull request most recent head 4d29312. Consider uploading reports for the commit 4d29312 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   21.24%   21.22%   -0.02%     
==========================================
  Files         530      531       +1     
  Lines       36760    36818      +58     
==========================================
+ Hits         7811     7816       +5     
- Misses      28374    28427      +53     
  Partials      575      575              
Files Changed Coverage Δ
pkg/bbgo/order_executor_simple.go 0.00% <0.00%> (ø)
pkg/types/market.go 35.29% <0.00%> (-4.71%) ⬇️
pkg/bbgo/activeorderbook.go 19.56% <33.33%> (+0.53%) ⬆️
pkg/bbgo/order_executor_general.go 16.08% <40.00%> (+0.51%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8118e55...4d29312. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 849 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 888 BBG

@c9s c9s enabled auto-merge August 4, 2023 18:41

var log = logrus.WithField("strategy", ID)

var stableCoins = []string{"USDT", "USDC"}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be pulled out later

@c9s c9s merged commit 616e939 into main Aug 4, 2023
2 checks passed
@c9s c9s deleted the c9s/strategy-convert branch August 4, 2023 18:46
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 903 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xfed6c473265f5937f5d2b9eef72bd9e0e17ea955301e73098ed51a0e1d7f73cf

Thank you for your contribution!

@c9s c9s restored the c9s/strategy-convert branch August 5, 2023 07:59
@c9s c9s deleted the c9s/strategy-convert branch August 5, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants