FEATURE: [indicator] add v2 MACD, SMA #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 483 BBG. |
c9s
changed the title
c9s
commented
Jun 1, 2023
| @@ -82,21 +81,3 @@ func (inc *SMA) LoadK(allKLines []types.KLine) { | |||
| inc.PushK(k) | |||
| } | |||
| } | |||
|
|
|||
| func calculateSMA(kLines []types.KLine, window int, priceF KLineValueMapper) (float64, error) { | |||
|
Re-estimated karma: this pull request may get 498 BBG |
gx578007
reviewed
Jun 1, 2023
pkg/datatype/floats/slice.go
Outdated
| @@ -191,14 +191,18 @@ func (s Slice) Last(i int) float64 { | |||
| return s[length-1-i] | |||
| } | |||
|
|
|||
| func (s Slice) Truncate(size int) Slice { | |||
| if len(s) < size { | |||
| return s | ||
| } | ||
|
|
||
| return s[len(s)-size:] |
There was a problem hiding this comment.
What if size is less than or equal to 0?
narumiruna
approved these changes
Jun 1, 2023
|
Re-estimated karma: this pull request may get 604 BBG |
gx578007
approved these changes
Jun 1, 2023
|
Re-estimated karma: this pull request may get 624 BBG |
|
Hi @c9s, Well done! 629 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xf5110b44dc5af4646d0340505869529186690ff4064a5e89d8f3afbff35339f5 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.