Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-order command error #1037

Closed
liaochy opened this issue Dec 30, 2022 · 3 comments
Closed

get-order command error #1037

liaochy opened this issue Dec 30, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@liaochy
Copy link

liaochy commented Dec 30, 2022

executing get-ordercommand
../bin/bbgo-slim get-order --order-id 16863344284 --session=binance --symbol=BTCUSDT --dotenv .env.binance.btcusdt

Result
FATAL cannot execute command error=<APIError> code=-1105, msg=Parameter 'symbol' was empty.

cmd/orders.go service.QueryOrder should add symbol to Parameter list
@liaochy
Copy link
Author

liaochy commented Dec 30, 2022

Binance api document https://binance-docs.github.io/apidocs/spot/cn/#user_data-20

@c9s c9s added the bug Something isn't working label Dec 30, 2022
@c9s
Copy link
Owner

c9s commented Dec 30, 2022

looks like they changed the API

lanphan added a commit to lanphan/bbgo that referenced this issue Mar 27, 2024
@lanphan
BUGFIX: issue c9s#1037, get-order command error
cf6989b
@lanphan lanphan mentioned this issue Mar 27, 2024
Merged
lanphan added a commit to lanphan/bbgo that referenced this issue Mar 27, 2024
@lanphan
BUGFIX: issue c9s#1037, get-order command error
bebbd68
lanphan added a commit to lanphan/bbgo that referenced this issue Mar 28, 2024
@lanphan
BUGFIX: issue c9s#1037, get-order command error
dc77c08
c9s added a commit that referenced this issue Mar 28, 2024
@c9s
Merge pull request #1606 from lanphan/get-order
bbc4fc9 
FIX: issue #1037, get-order command error
@lanphan
Copy link
Contributor

lanphan commented Mar 28, 2024

this is fixed, you can close it, @c9s

@liaochy liaochy closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@c9s @lanphan @liaochy