Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential copy changes to make it flow a little bit more smoothly. #1

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

mrmrs
Copy link
Member

@mrmrs mrmrs commented Sep 11, 2017

No description provided.

Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from my comments.

To get started choose a folder for a new project, where Lab will save a `lab.json` and `theme.json` file.
We recommend you keep this folder under source control, such as git.
First, choose a folder for a new project. This can be an existing react project that has a collection of components. Lab will save a `lab.json` and `theme.json` file.
We recommend you keep this folder under source control, using such as [git](https://git-scm.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using something like git

@@ -82,7 +81,7 @@ All values need to be JavaScript strings, which means they should be enclosed in

## Importing Components

React component created outside of Lab can be imported to view them side-by-side and with different example props.
A react component created outside of Lab can be imported to Lan. You can view them side-by-side and with different example props.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lab*

@@ -1,35 +1,34 @@

## Getting Started

To get started choose a folder for a new project, where Lab will save a `lab.json` and `theme.json` file.
We recommend you keep this folder under source control, such as git.
First, choose a folder for a new project. This can be an existing react project that has a collection of components. Lab will save a `lab.json` and `theme.json` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize React

Next, click on the *Components* tab to view the library of UI components.
You‘ll see an empty screen to start with, so you‘ll need to create some components.
Next, click on the *Components* (⌘1) tab to view the library of UI components.
You‘ll see an empty screen to start with, so you‘ll need to create or import some components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted the first part to be specifically about the component creation flow – it gets into importing later in the doc

@jxnblk
Copy link
Member

jxnblk commented Sep 11, 2017

:shipit:

@mrmrs mrmrs merged commit dfb499b into master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants