Skip to content

Commit 7584db9

Browse files
authored
Fix login exception. (google#1979)
1 parent 4e5f6e5 commit 7584db9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/appengine/handlers/login.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from libs import helpers
2424
from metrics import logs
2525

26+
DEFAULT_REDIRECT = '/'
2627
SESSION_EXPIRY_DAYS = 14
2728

2829

@@ -33,7 +34,7 @@ class Handler(base_handler_flask.Handler):
3334
@handler_flask.unsupported_on_local_server
3435
def get(self):
3536
"""Handle a get request."""
36-
dest = request.get('dest')
37+
dest = request.get('dest', DEFAULT_REDIRECT)
3738
base_handler_flask.check_redirect_url(dest)
3839

3940
return self.render(
@@ -78,6 +79,6 @@ def get(self):
7879
# Even if the revoke failed, remove the cookie.
7980
logs.log_error('Failed to revoke session cookie.')
8081

81-
response = self.redirect(request.get('dest'))
82+
response = self.redirect(request.get('dest', DEFAULT_REDIRECT))
8283
response.delete_cookie('session')
8384
return response

0 commit comments

Comments
 (0)