Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing of node attributes in J2602 LDF file #130

Merged
merged 42 commits into from
Jan 30, 2024

Conversation

nuts4coffee
Copy link
Contributor

@nuts4coffee nuts4coffee commented Jan 29, 2024

Brief

  • Allow parse of LDF files with "wakeup_time" and "poweron_time" node attributes.

Reference: J2602_3 Oct 2021:

image

Checklist

  • Add relevant labels to the Pull Request
  • Review test results and code coverage
    • Review snapshot test results for deviations
  • Review code changes
    • Create relevant test scenarios
    • Update examples
    • Update JSON schema
  • Update documentation
    • Update examples in README
  • Update changelog
  • Update version number

Resolves

  • Describe the bug or feature and link to relevant issues

Evidence

  • Analyze how the change might impact existing code

  • Provide evidence that the feature is tested and covered properly

Yan Du and others added 30 commits June 1, 2023 15:08
Add support for protocol version J2602_1_1.0
Fix issue with decode/encode signals of list type
Bump version number
Encode to LSB for multi-byte array signals
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63ae6cc) 96.28% compared to head (b5eb268) 96.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   96.28%   96.30%   +0.02%     
==========================================
  Files          13       13              
  Lines        1453     1463      +10     
==========================================
+ Hits         1399     1409      +10     
  Misses         54       54              
Flag Coverage Δ
3.10 96.30% <100.00%> (+0.02%) ⬆️
3.11 96.30% <100.00%> (+0.02%) ⬆️
3.12 96.30% <100.00%> (+0.02%) ⬆️
3.6 96.30% <100.00%> (+0.02%) ⬆️
3.7 96.30% <100.00%> (+0.02%) ⬆️
3.8 96.30% <100.00%> (+0.02%) ⬆️
3.9 96.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuts4coffee
Copy link
Contributor Author

@c4deszes Could you please help review this change? I notice some pipeline jobs have failed but I don't think they're related to my changes. Please let me know if there is anythng to fix on my end. Thanks.

@c4deszes c4deszes merged commit 31b4fa6 into c4deszes:master Jan 30, 2024
14 of 15 checks passed
@c4deszes c4deszes added ldf/nodes Related to LIN nodes parser Related to the LDF parsing j2602 SAE LIN standard labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
j2602 SAE LIN standard ldf/nodes Related to LIN nodes parser Related to the LDF parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants