-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing of node attributes in J2602 LDF file #130
Conversation
…o version class to indicate J2602 status.
Add support for protocol version J2602_1_1.0
Mark unit tests
Introduce class J2602Version
… W503 are conflicting rules.
Fix flake8 linter errors.
Fix issue with decode/encode signals of list type
Bump version number
Encode to LSB for multi-byte array signals
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 96.28% 96.30% +0.02%
==========================================
Files 13 13
Lines 1453 1463 +10
==========================================
+ Hits 1399 1409 +10
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@c4deszes Could you please help review this change? I notice some pipeline jobs have failed but I don't think they're related to my changes. Please let me know if there is anythng to fix on my end. Thanks. |
Brief
Reference: J2602_3 Oct 2021:
Checklist
Resolves
Evidence
Analyze how the change might impact existing code
Provide evidence that the feature is tested and covered properly