Fix x-grid-lines to not get pushed down by top padding. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… behind ygrids in the z-index.
|
Oops, my other commit to move xgridLines up in the z-order above ygrids got included here as well. Here's an example before: And here's after both commits: |
masayuki0812
added a commit
that referenced
this pull request
Jun 20, 2014
|
Hi, Thank you for the PR, but I've fixed this issue by this commit 6f2091f . And I fixed the issue about z-index of grids by the commit above, so I'll close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix additional problem with Issue #368 related to x-grid-lines. Padding should not push down x-grid-lines.
Without Fix:
http://jsfiddle.net/99XZt/3/
With Fix:
http://jsfiddle.net/99XZt/4/