Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1691 #2761

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Fix #1691 #2761

merged 1 commit into from
Feb 26, 2020

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 26, 2020

This PR changes the way of looking up the key from the json object based on #1694.

closes #1691

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #2761 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
+ Coverage    82.9%   82.91%   +<.01%     
==========================================
  Files          60       60              
  Lines        4791     4793       +2     
==========================================
+ Hits         3972     3974       +2     
  Misses        819      819
Impacted Files Coverage Δ
src/data.convert.js 88.73% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0e523...67d97d5. Read the comment docs.

Co-authored-by: Jakob Kneissl <j_the_k@web.de>
@kt3k kt3k merged commit 49b7975 into master Feb 26, 2020
@kt3k kt3k deleted the issue-1694 branch February 26, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create chart with json and dot in key
2 participants