Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bundle resources to .gitignore #2675

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Conversation

panthony
Copy link
Contributor

@panthony panthony commented Aug 9, 2019

When you contribue to the documentation, using RVM & bundle creates new files locally.

They are dev specific to let's add them to .gitignore

@codecov-io
Copy link

Codecov Report

Merging #2675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2675   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          59       59           
  Lines        4537     4537           
=======================================
  Hits         3643     3643           
  Misses        894      894

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2f039...4ca0895. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #2675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2675   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          59       59           
  Lines        4537     4537           
=======================================
  Hits         3643     3643           
  Misses        894      894

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2f039...4ca0895. Read the comment docs.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@kt3k kt3k merged commit bdf12d1 into c3js:master Aug 10, 2019
panthony added a commit to cogniteev/c3 that referenced this pull request Aug 12, 2019
beninsocrata pushed a commit to socrata/c3 that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants