Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only skip animation if !isTabVisible, not the whole rendering #2671

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

panthony
Copy link
Contributor

@panthony panthony commented Aug 8, 2019

It fixes a regression introduced by f4a163f and closes #2533

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #2671 into master will decrease coverage by <.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
- Coverage   80.13%   80.12%   -0.01%     
==========================================
  Files          57       57              
  Lines        4520     4519       -1     
==========================================
- Hits         3622     3621       -1     
  Misses        898      898
Impacted Files Coverage Δ
src/core.js 90.11% <95.23%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c971c...3b575d6. Read the comment docs.

@panthony
Copy link
Contributor Author

panthony commented Aug 8, 2019

Hum... I just saw this commit: 19a54ec but it did not fixed the issue for me.

The pies are here, the line's dot are here, but not the bars, not the lines.

if I click back on the tab, the focus event is not sent but document.hidden is false. If I click anywhere in the window when the focus event is sent.

I'm using Chrome 75.

Moreover, all my charts (and I mean several dozens) are now redrawn just because I switched tab which is annoying, I think i'll have to revert that part for me.

@panthony panthony closed this Aug 8, 2019
@panthony panthony deleted the patch-0 branch August 8, 2019 13:05
@panthony panthony restored the patch-0 branch August 8, 2019 13:07
@panthony panthony reopened this Aug 8, 2019
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panthony Thanks! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isTabVisible prevents chart being rendered
3 participants