-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not seeing mouseover events for area-spline chart #575
Comments
Hi, I've faced a similar issue before. "point: {show: false}" caused the issue for me. When I removed that line, it worked all fine. |
Thank you for reporting. I think this has been fixed now. Could you try the latest code again? Thanks. |
I just tested, and it looks like this bug is fixed; thanks! The |
@masayuki0812 this fix causes a performance reduce when rendering a chart with many lines. I try to understand what is the reason. |
@sineed Thank you for considering this. I think the reason is the number of circles, which are generated for each data point and required to handle mouse events. Now I don't have any good idea to solve this, but this would be a workaround if you don't need mouse events:
This changes not to append circles and disable its transition. |
@masayuki0812 thanks for quick response and your WA. For me it's OK to use this solution, but it's not good when I need event handling of circles in group of charts, and for the rest I don't need events at all. Maybe it will be another override of mentioned functions... |
@sineed As you said, it's not easy to enable a part of event handling while removing circles. I think we need to change how to handle the events in the future (e.g. use only one event rect and handle events only from it). |
I'm just getting started with c3 and trying to add a mouseover event listener for an area-spline chart. Here's my rough code:
When I run the above code and move the mouse around on the plot, I don't see anything printing in the console. Looking at
src/interaction.js
, I see this code around line 137:If I change
CLASS.shape
toCLASS.eventRect
, I start seeing console output for mouseover. I don't know this code at all, so I don't know if this is a bug or if I'm just using the API wrong. Maybe this code needs to be conditioned on the type of plot?The text was updated successfully, but these errors were encountered: