Legend is off-centre

[aendra-rininsland]

I noticed this in relation to times/axisJS#9, but it seems the legend is slightly off-centre.

Using Photoshop, I've drawn where the centre of each element is, and they're clearly a bit unaligned:

I may write a PR for this given that my project needs to have this fixed.

[masayuki0812]

You're right and I think this has been fixed by this commit. Could you try the latest code? Thanks.

[aendra-rininsland]

Looks pretty close, if not spot-on — via my not-very scientific use of Photoshop to find the centres of each element (Creating a selection to each edge, transforming its width to 1px, drawing vertical line. There's totally a better way to do this in SVG, I'm sure...), they still seem about a pixel off, though this could just be due to an issue converting vector to raster via screencap, or a rounding issue with the size of the graph I made:

I'm satisfied with it, nicely done! Closing issue — many thanks, will update axisJS now! 👍

[aendra-rininsland]

Actually, reopening because you have a testing framework and this shouldn't be a difficult thing to write a test for. Will try to do a pull request on Monday containing a test not involving silly stuff done in Photoshop!

[masayuki0812]

I added a test for this issue. So, please let me close. Thanks.

[aendra-rininsland]

Thanks for doing that! Have been swamped at work and totally forgot about writing that test!