Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency of arg names in flow and load #314

Closed
lblb opened this issue Jun 3, 2014 · 2 comments
Closed

Inconsistency of arg names in flow and load #314

lblb opened this issue Jun 3, 2014 · 2 comments
Labels
C-feature-request Category: A feature request or an enhancement resolved maybe

Comments

@lblb
Copy link

lblb commented Jun 3, 2014

Hi I noticed that API load/unload function has callback named "done", but flow has "onend". Please rename for consistency.
@masayuki0812
Copy link
Member

Hi, I agree. I'll do that in the next version. Thanks.

masayuki0812 added a commit that referenced this issue Jun 4, 2014
@masayuki0812
Rename onend to done in flow API - #314
b8c21eb
@masayuki0812
Copy link
Member

I renamed onend to done. Thank you for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request or an enhancement resolved maybe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masayuki0812 @lblb