[feat] Support for dynamic themes

[ayangweb]

Hey, thanks for such a great plugin, I'm currently using tauri-plugin-theme for dynamic theme switching, is it possible to provide a theme parameter to dynamically change the theme color of the menu?

[c2r0b]

Yes, that should be doable. I am going to work on it

[ayangweb]

Yes, that should be doable. I am going to work on it

Thank you, it's really great and I'm already looking forward to it!

[c2r0b]

The themes implementation for macOS should work now in the dev branch.
I am trying to find a way to support Linux and Windows too.

To try out the macOS version you can import the plugin like this:

tauri-plugin-context-menu = { git = "https://github.com/c2r0b/tauri-plugin-context-menu", branch = "dev" }

You can then pass the option theme that is either light or dark to the plugin (updated docs here).

[ayangweb]

The themes implementation for macOS should work now in the dev branch. I am trying to find a way to support Linux and Windows too.

To try out the macOS version you can import the plugin like this:

tauri-plugin-context-menu = { git = "https://github.com/c2r0b/tauri-plugin-context-menu", branch = "dev" }

You can then pass the option theme that is either light or dark to the plugin (updated docs here).

Okay, thanks, that's really great!

[ayangweb]

The themes implementation for macOS should work now in the dev branch. I am trying to find a way to support Linux and Windows too.

To try out the macOS version you can import the plugin like this:

tauri-plugin-context-menu = { git = "https://github.com/c2r0b/tauri-plugin-context-menu", branch = "dev" }

You can then pass the option theme that is either light or dark to the plugin (updated docs here).

Works fine on MacOS 🥰

[c2r0b]

I went ahead and published v0.8 with MacOS theme option support.

Unfortunately, both Windows and Linux (Gtk) do not seem to have a way to handle theme changes for a single widget 😓
Instead, they always fall back to the global window theme.

tauri-plugin-theme changes the window theme, therefore it should change the menu theme automatically (on Windows and Linux).
Please let me know if you have time to confirm this.

[ayangweb]

I went ahead and published v0.8 with MacOS theme option support.

Unfortunately, both Windows and Linux (Gtk) do not seem to have a way to handle theme changes for a single widget 😓 Instead, they always fall back to the global window theme.

tauri-plugin-theme changes the window theme, therefore it should change the menu theme automatically (on Windows and Linux). Please let me know if you have time to confirm this.

Windows：

Windows tests are not following the window theme, and Linux I don't have a test machine at the moment!

[c2r0b]

Thank you for the test.
I am going to look into the Windows issue and update this thread

[ayangweb]

Thank you for the test. I am going to look into the Windows issue and update this thread

Well, thank you! 😁

[c2r0b]

I made some tests, but I could not figure out how to make Windows context menu appearance light or dark on demand (tried on Windows 10).

Help is wanted on this 🙏

[ayangweb]

I made some tests, but I could not figure out how to make Windows context menu appearance light or dark on demand (tried on Windows 10).

Help is wanted on this 🙏

Maybe tauri v1 really doesn't have a way to implement dynamic themes in windows! wyhaya/tauri-plugin-theme#5 (comment)

linux：Could see if this helps. https://github.com/wyhaya/tauri-plugin-theme/blob/main/src/platform/linux.rs