Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx publish workflow #3

Merged
merged 15 commits into from
Sep 15, 2024
Merged

Fx publish workflow #3

merged 15 commits into from
Sep 15, 2024

Conversation

spartan-ductduong
Copy link
Contributor

Summary

Enhance the publish workflow with improved authentication.

Why

The workflow failed due to the use of GitHub App credentials for authenticating to GHCR. Currently, only classic or fine-grained personal access tokens are supported for authentication.

What

Switch the authentication method for GHCR to use a PAT.

  • ❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🕷 Bug fix (non-breaking change which fixes an issue)
  • 👏 Performance optimization (non-breaking change which addresses a performance issue)
  • 🛠 Refactor (non-breaking change which does not change existing behavior or add new functionality)
  • 📗Library update (non-breaking change that will update one or more libraries to newer versions)
  • 📝 Documentation (non-breaking change that doesn't change code behavior, can skip testing)
  • ✅ Test (non-breaking change related to testing)
  • 🔒 Security awareness (changes that effect permission scope, security scenarios)

Test Plan

Checklist:

  • I have performed a self-review of my own code
  • I have tested that the feature or bug fix works as expected
  • I have included helpful comments, particularly in hard-to-understand areas
  • I have added tests that prove my changes are functioning
  • New and existing unit tests pass locally with my changes

Related Issues

@spartan-ductduong spartan-ductduong requested a review from a team as a code owner September 15, 2024 10:56
@spartan-ductduong spartan-ductduong merged commit 231e986 into master Sep 15, 2024
1 check passed
@spartan-ductduong spartan-ductduong deleted the ducdt/fix-publish-workflow branch September 15, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant