V1.1 #2
Merged
V1.1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having two will allow the editing of one or the other. Also, configured it so that the functions can be used to update other fields and not just timestamp. Makes it a little damp but will look into a DRYer approach later.
SQLAlchemy will ignore the extra data that isn't apart of the model. This allows the use of the same dataset to be sent to both, making things a bit DRYer since both user and server model receive identical information.
In progress.
?setup potentially cause errors when on_message is triggered before ?setup runs (looking into a potential alternate fix). ?ping will get the timestamp of the command, defeating the purpose of the command. May or may not have it ignore all commands in the future.
Also during last refactor, forgot to re-include the Guild ID.
Improved error handling and ping is now an admin/mod command. Changed the nature of the ping command. It is essentially a message sent to a user via dm if allowed, other wise it will notify them in the appropriate channel (preferably the system channel). It's intended as a pre-warning before the bot marks them as inactive and again a few days before they are kicked for inactivity. Any admin or mod can use this command manually. It requires that the admin create either (or both) a role named Moderator and/or Administrator role. This is problematic as each server has their own idea on what these roles are called. Potential solution: add a global variable outside of the class. The setup command (and will also attempt to do so upon the triggering of on_guild_join in setup_tasks.py)would then ask the admin to list their moderator/admin roles and save these roles to the database for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.