Fix iPhone X frame #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than drawing orthogonal lines from the centre to measure the screen size, this uses a flood fill algorithm, and measures the size of the resulting shape. Please note I'm maintaining a fork of this project on my account, as I need the output in a different format
|
@jacobp100 Good stuff! I'm checking it out and it seems to work pretty well. One thing I noticed is that the parse-frames.js function is significantly slower (which makes sense), however I can get a ~50% speedup by using the cluster module:
I'll work on opening a PR for that after I get yours fully tested and merged. |
|
Actually looks like part of it was either just load on my machine or I was potentially running under node 6. Node 8 looks like this:
Much better! |
|
That's huge! Looks like the improvements in node are really showing off! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than drawing orthogonal lines from the centre to measure the screen size, this uses a flood fill algorithm, and measures the size of the resulting shape.
Please note I'm maintaining a fork of this project on my account, as I need the output in a different format