Skip to content

Commit

Permalink
audit: Update kdoc for audit_send_reply and audit_list_rules_send
Browse files Browse the repository at this point in the history
The kbuild test robot reported:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
> head:   6f285b1
> commit: 6f285b1 [2/2] audit: Send replies in the proper network namespace.
> reproduce: make htmldocs
>
> >> Warning(kernel/audit.c:575): No description found for parameter 'request_skb'
> >> Warning(kernel/audit.c:575): Excess function parameter 'portid' description in 'audit_send_reply'
> >> Warning(kernel/auditfilter.c:1074): No description found for parameter 'request_skb'
> >> Warning(kernel/auditfilter.c:1074): Excess function parameter 'portid' description in 'audit_list_rules_s

Which was caused by my failure to update the kdoc annotations when I
updated the functions.  Fix that small oversight now.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

ebiederm committed Mar 8, 2014
1 parent 6f285b1 commit d211f17
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion kernel/audit.c
Original file line number Diff line number Diff line change
@@ -559,7 +559,7 @@ static int audit_send_reply_thread(void *arg)
}
/**
* audit_send_reply - send an audit reply message via netlink
* @portid: netlink port to which to send reply
* @request_skb: skb of request we are replying to (used to target the reply)
* @seq: sequence number
* @type: audit message type
* @done: done (last) flag
2 changes: 1 addition & 1 deletion kernel/auditfilter.c
Original file line number Diff line number Diff line change
@@ -1067,7 +1067,7 @@ int audit_rule_change(int type, __u32 portid, int seq, void *data,

/**
* audit_list_rules_send - list the audit rules
* @portid: target portid for netlink audit messages
* @request_skb: skb of request we are replying to (used to target the reply)
* @seq: netlink audit message sequence (serial) number
*/
int audit_list_rules_send(struct sk_buff *request_skb, int seq)

0 comments on commit d211f17

Please sign in to comment.