Skip to content

Commit

Permalink
[PATCH] w1: cleanups.
Browse files Browse the repository at this point in the history
 - white space changes.
 - list_for_each_entry/list_for_each_entry_safe and reverse changes.
 - small coding style changes.
 - removed redundant NULL checks.
 - use attribute group and macros instead of direct device attributes.
Patch is havily based on work from Adrian Bunk and Dmitry Torokhov,
thanks guys.

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Evgeniy Polyakov authored and gregkh committed Jun 22, 2005
1 parent 85e941c commit 7785925
Show file tree
Hide file tree
Showing 14 changed files with 171 additions and 256 deletions.
16 changes: 8 additions & 8 deletions drivers/w1/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ menu "Dallas's 1-wire bus"
config W1
tristate "Dallas's 1-wire support"
---help---
Dallas's 1-wire bus is usefull to connect slow 1-pin devices
Dallas's 1-wire bus is usefull to connect slow 1-pin devices
such as iButtons and thermal sensors.

If you want W1 support, you should say Y here.

This W1 support can also be built as a module. If so, the module
Expand All @@ -17,8 +17,8 @@ config W1_MATROX
help
Say Y here if you want to communicate with your 1-wire devices
using Matrox's G400 GPIO pins.
This support is also available as a module. If so, the module

This support is also available as a module. If so, the module
will be called matrox_w1.ko.

config W1_DS9490
Expand All @@ -27,17 +27,17 @@ config W1_DS9490
help
Say Y here if you want to have a driver for DS9490R UWB <-> W1 bridge.

This support is also available as a module. If so, the module
This support is also available as a module. If so, the module
will be called ds9490r.ko.

config W1_DS9490_BRIDGE
config W1_DS9490R_BRIDGE
tristate "DS9490R USB <-> W1 transport layer for 1-wire"
depends on W1_DS9490
help
Say Y here if you want to communicate with your 1-wire devices
using DS9490R USB bridge.

This support is also available as a module. If so, the module
This support is also available as a module. If so, the module
will be called ds_w1_bridge.ko.

config W1_THERM
Expand All @@ -51,7 +51,7 @@ config W1_SMEM
tristate "Simple 64bit memory family implementation"
depends on W1
help
Say Y here if you want to connect 1-wire
Say Y here if you want to connect 1-wire
simple 64bit memory rom(ds2401/ds2411/ds1990*) to you wire.

endmenu
10 changes: 5 additions & 5 deletions drivers/w1/matrox_w1.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/*
* matrox_w1.c
* matrox_w1.c
*
* Copyright (c) 2004 Evgeniy Polyakov <johnpol@2ka.mipt.ru>
*
*
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
Expand Down Expand Up @@ -59,7 +59,7 @@ static struct pci_driver matrox_w1_pci_driver = {
.remove = __devexit_p(matrox_w1_remove),
};

/*
/*
* Matrox G400 DDC registers.
*/

Expand Down Expand Up @@ -177,8 +177,8 @@ static int __devinit matrox_w1_probe(struct pci_dev *pdev, const struct pci_devi

dev->bus_master = (struct w1_bus_master *)(dev + 1);

/*
* True for G400, for some other we need resource 0, see drivers/video/matrox/matroxfb_base.c
/*
* True for G400, for some other we need resource 0, see drivers/video/matrox/matroxfb_base.c
*/

dev->phys_addr = pci_resource_start(pdev, 1);
Expand Down
Loading

0 comments on commit 7785925

Please sign in to comment.