Skip to content

Commit

Permalink
ufs: copy symlink data into the correct union member
Browse files Browse the repository at this point in the history
Copy symlink data into the union member it is accessed through. Although
this shouldn't make a difference to behaviour it makes the code easier
to follow and grep through. It may also prevent problems if the
struct/union definitions change in the future.

Signed-off-by: Duane Griffin <duaneg@dghda.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
duaneg authored and Al Viro committed Mar 27, 2009
1 parent b12903f commit 723be1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ufs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry,
} else {
/* fast symlink */
inode->i_op = &ufs_fast_symlink_inode_operations;
memcpy((char*)&UFS_I(inode)->i_u1.i_data,symname,l);
memcpy(UFS_I(inode)->i_u1.i_symlink, symname, l);
inode->i_size = l-1;
}
mark_inode_dirty(inode);
Expand Down

0 comments on commit 723be1f

Please sign in to comment.