Error with python3.7

[NameLessJedi]

• Satel Integra version: 0.2.0
• Python version: 3.7.2 (python3.7_3.7.2-1_amd64.deb)
• Operating System: Debian Sid/Unstable

Description

Debian Sid moved to python 3.7 as main python3 interpreter so I created fresh venv for HomeAssistant and installed from scratch.
During HA start there is:

hass[2286]: /home/hass/ha37/lib/python3.7/site-packages/satel_integra/satel_integra.py:327: RuntimeWarning: coroutine 'StreamReader.readuntil' was never awaited
hass[2286]: data = yield from self._reader.readuntil(b'\xFE\x0D')
hass[2286]: RuntimeWarning: Enable tracemalloc to get the object allocation traceback
hass[2286]: 2019-01-25 09:51:29 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
hass[2286]: Traceback (most recent call last):
hass[2286]: File "/home/hass/ha37/lib/python3.7/site-packages/satel_integra/satel_integra.py", line 398, in monitor_status
hass[2286]: yield from self.start_monitoring()
hass[2286]: File "/home/hass/ha37/lib/python3.7/site-packages/satel_integra/satel_integra.py", line 172, in start_monitoring
hass[2286]: resp = yield from self._read_data()
hass[2286]: File "/home/hass/ha37/lib/python3.7/site-packages/satel_integra/satel_integra.py", line 327, in _read_data
hass[2286]: data = yield from self._reader.readuntil(b'\xFE\x0D')
hass[2286]: TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

and the component is not working.

[c-soft]

Thanks for finding it. I'll try to fix it with the next release.

[NameLessJedi]

Any ETA?
According to home-assistant/core#20988 there can be some more ppl switching to python 3.7

[c-soft]

I'm fixing some issues currently, so I hope to get it done too. Problem is I don't have environment with python 3.7 to reproduce the issue. Would you be willing to test it for me once I got fix attempt?
Testing is about copying custom component to the config dir of HA.

[c-soft]

I think I this issue, but it's not tested with Python 3.7.
Before new version is released officially you can test it out by copying contents of this zip:
https://www.dropbox.com/s/q3363q9lqofbiwk/satel_integra.zip?dl=0

... to config\homeassistant\components directory.

Thanks!

[NameLessJedi]

I've been away during weekend. Downloaded zip just now and will try it in the evening (I hope I did not remove python3.7 venv ;) )

[c-soft]

What's dlib?
can you share the logs please?

[jfarcher]

Sorry ignore my previous comment, wrong project

[NameLessJedi]

Works! 👍 :)
Tested also with python 3.6 venv and also no errors.
Will observe this for day or two before closing if that's ok with you :)
BTW this should be put in custom_components not components in HA config dir

[c-soft]

Good to hear :)
Give it a good testing before closing :)

Regarding custom_components vs cumponents: if you put it in custom_components it won't work correctly (at least it didn't for me) because it will clash with already existing component within HA.
Interesingly enough, it sorta worked for me but not quite this way.

[NameLessJedi]

I've spoke too soon.
This morning I've spotted that it's unable to read state (armed/disarmed). It stays unknown :/

Somehow it won't work when put in component or components dir. Spits same error as before. Most probably because it downgrades satel_integra to 0.2.0. When I put it in custom_components it properly pulls satel_integra 0.3.2 :
lut 20 12:25:33 rhenvar hass[17318]: 2019-02-20 12:25:33 INFO (MainThread) [homeassistant.loader] Loaded satel_integra from custom_components.satel_integra
lut 20 12:25:33 rhenvar hass[17318]: 2019-02-20 12:25:33 WARNING (MainThread) [homeassistant.loader] You are using a custom component for satel_integra which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you do experien
lut 20 12:25:33 rhenvar hass[17318]: 2019-02-20 12:25:33 INFO (SyncWorker_6) [homeassistant.util.package] Attempting install of satel_integra==0.3.2
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [homeassistant.setup] Setting up satel_integra
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [homeassistant.setup] Setup of domain satel_integra took 0.0 seconds.
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Starting monitor_status loop
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x00
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [homeassistant.setup] Setting up zeroconf
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [homeassistant.loader] Loaded alarm_control_panel.satel_integra from homeassistant.components.alarm_control_panel.satel_integra
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x09
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x0a
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x0b
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x10
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [homeassistant.components.alarm_control_panel] Setting up alarm_control_panel.satel_integra
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x13
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x17
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Ignoring message: 0x1f
lut 20 12:25:38 rhenvar hass[17318]: 2019-02-20 12:25:38 INFO (MainThread) [satel_integra.satel_integra] Calling handler for id: 0x2a
lut 20 12:25:51 rhenvar hass[17318]: 2019-02-20 12:25:51 INFO (MainThread) [homeassistant.loader] Loaded binary_sensor.satel_integra from homeassistant.components.binary_sensor.satel_integra
lut 20 12:25:51 rhenvar hass[17318]: 2019-02-20 12:25:51 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up binary_sensor.satel_integra
lut 20 12:25:58 rhenvar hass[17318]: 2019-02-20 12:25:58 INFO (MainThread) [satel_integra.satel_integra] Ignoring message: 0xee
lut 20 12:26:18 rhenvar hass[17318]: 2019-02-20 12:26:18 INFO (MainThread) [satel_integra.satel_integra] Ignoring message: 0xee

that last message repeats every 30s or so.

[nyxnyx]

I had an error related to asyncio.coroutine.
Adding one line to satel_integra.py (an HA component file) helped to fix it:

  325     @asyncio.coroutine
  326     def _read_data(self):

[NameLessJedi]

@c-soft that component vs custom_components might be related to HA version? I'm on 0.86.2 and while browsing announcement about 0.88 I've spotted some changes around custom components. I'll wait a bit for 0.88.1+ and will update
Just to make sure by config\homeassistant you mean config dir, right? The place where configuration.yaml is.
@nyxnyx With this change to 0.2.0 it runs w/o errors with python 3.7 and properly detects alarm state, but this won't work with 0.3.2 as it's rewritten to use async.

[nyxnyx]

@NameLessJedi currently I have only version 0.2.0. My problem was with errors under python 3.7 - now they gone. If I have time - I will try to upgrade to 0.3.2 and see what is going on.
@c-soft thank you for your effort!

[c-soft]

@NameLessJedi can you attach full log on a debug level?
Please remember to turn on debug for both the library (as you already have) and HA component.

[NameLessJedi]

I've been trying to pinpoint just the satel component debug but so far I failed. Can you help with proper logger: config? I've even tried to put homeassistant.components: debug but this doesn't seem to affect Satel